Re: [w3c/ServiceWorker] Add 1024 as the number of router rule registration limit (PR #1752)

@yoshisatoyanagisawa commented on this pull request.



> @@ -3409,6 +3418,9 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
 
           1. If running the [=Verify Router Condition=] algorithm with |condition|["{{RouterCondition/not}}"] and |serviceWorker| returns false, return false.
           1. Set |hasCondition| to true.
+      1. If |hasCondition| is true, then:
+          1. Increament |serviceWorker|'s [=service worker/router rule count=] by one.

It sounds like the router rule count kept on incremented even if verify fails later. i.e. addRoutes() failed.
Also, if or/not is nested, they may cause +1 per nest.  Is it intended?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1752#pullrequestreview-2582945404
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1752/review/2582945404@github.com>