Re: [w3c/ServiceWorker] Ensure the addRoutes() to be called within the install event (PR #1744)

@youennf can I ask you to clarify the followings?  Or, will you show some snippets that make things different?

> The order of route validation might be slightly different after the PR (in case one route is invalid and the other has a fetch source but there is no registered fetch event handler).

The PR clearly separated the verification and the update.  However, a process before the PR still returns promise reject on the verify failure without updating the `|serviceWorker|'s [=service worker/list of router rules=]`.  Therefore, I still think `addRoutes()` is atomic.  i.e. if there is a invalid rule, `addRoutes()` just fails and `[=service worker/list of router rules=]` won't be updated.
I suppose the rules order still preserved.

Stepping back, do you suggest to add WPT that failing `addRoutes()` are just ignored?
i.e. `addRoutes()` invalid and `addRoutes()` valid are called in this order, the ServiceWorker should respect the latter `addRoutes()`.  You might suggest to add WPTs for this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1744#issuecomment-2620888877
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1744/c2620888877@github.com>