Re: [w3c/ServiceWorker] Ensure the addRoutes() to be called within the install event (PR #1744)

@youennf approved this pull request.

LGTM.
I think we still need to work on the in parallel/queue a task, but this can be done as part of https://github.com/w3c/ServiceWorker/issues/1742.

It would be useful to add some WPT tests:
- addRoutes after installing.
- The order of route validation might be slightly different after the PR (in case one route is invalid and the other has a fetch source but there is no registered fetch event handler).
- Call addRoutes several times and verify ordering is preserved when matching a fetch load.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1744#pullrequestreview-2577471454
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1744/review/2577471454@github.com>