- From: youennf <notifications@github.com>
- Date: Wed, 22 Jan 2025 00:27:31 -0800
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 22 January 2025 08:27:35 UTC
@youennf commented on this pull request. I have some questions: 1. Should addRoutes be callable only synchronously within the event handler or while the event is active (aka while the service worker is installing)? 2. Should addRoute execution delay installation of the service worker? 3. Should addRoutes promise rejection trigger automatic failure of the service worker or should it be let to the website? My preference so far: 1. Allow calling addRoutes while the event is active. 2. Have addRoute execution delay installation of the service worker. 3. Leave failure of the installation up to the website. Based on this, I would tend to keep the current API signature as is, `addRoutes(RouterRule or sequence)`. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1744#pullrequestreview-2566499552 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1744/review/2566499552@github.com>
Received on Wednesday, 22 January 2025 08:27:35 UTC