- From: Ming-Ying Chung <notifications@github.com>
- Date: Mon, 20 Jan 2025 21:28:39 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1647/review/2563507981@github.com>
@mingyc commented on this pull request. > -<a for="fetch record">controller</a> is non-null, and whose <a for="fetch record">request</a>'s -<a>done flag</a> is unset or <a for=request>keepalive</a> is false, -<a for="fetch controller">terminate</a> the <a for="fetch group">fetch record</a>'s -<a for="fetch record">controller</a>. +<p>When a <a for=fetch>fetch group</a> <var>fetchGroup</var> is +<dfn export for="fetch group" id=concept-fetch-group-terminate>terminated</dfn>: + +<ol> + <li><p><a for=list>For each</a> <a for="fetch group">fetch record</a> <var>record</var> of + <var>fetchGroup</var>'s <a for="fetch group">fetch records</a>, if <var>record</var>'s + <a for="fetch record">controller</a> is non-null and <var>record</var>'s + <a for="fetch record">request</a>'s <a>done flag</a> is unset and <a for=request>keepalive</a> is + false, <a for="fetch controller">terminate</a> <var>record</var>'s + <a for="fetch record">controller</a>. + + <li><p><a>Process deferred fetches</a> for <var>fetchGroup</var>. > Process deferred fetches for fetchGroup. Although this is when a document is terminating... There should be a step of "set activated to true" such that FetchLaterResult still gets the proper `activated` state after deferred fetch record being processed (previous invoke state approach has it right I think). -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1647#pullrequestreview-2563507981 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1647/review/2563507981@github.com>
Received on Tuesday, 21 January 2025 05:28:43 UTC