Re: [whatwg/dom] Introduce `moveBefore()` state-preserving atomic move API (PR #1307)

@domfarolino commented on this pull request.



> @@ -2872,6 +2872,135 @@ before a <var>child</var>, with an optional <i>suppress observers flag</i>, run
 </ol>
 
 
+<p><a lt="Other applicable specifications">Specifications</a> may define <dfn export
+id=concept-node-move-ext>moving steps</dfn> for all or some <a for=/>nodes</a>. The algorithm is

I fixed this instance, after finishing rewrapping this paragraph, no more jumped out at me. Maybe you have others in mind further down.

> It also seems okay to drop the explicit ID here as we stopped doing those.

Yeah I realize it isn't necessary, however I liked the formatting of `concept-node-move-ext` since it perfectly matches the other primitives that HTML links to, so it seemed nice for link consistency: https://github.com/whatwg/html/pull/10657/files#diff-41cf6794ba4200b839c53531555f0f3998df4cbb01a4d5cb0b94e3ca5e23947dR3290-R3291. If you want to remove it, feel free, just remember to update the HTML PR. Otherwise, I'd slightly slightly prefer keeping as-is.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1307#discussion_r1915447965
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1307/review/2550772011@github.com>

Received on Tuesday, 14 January 2025 18:55:54 UTC