Re: [w3c/IndexedDB] "Convert a value to a key" should return invalid for detached array buffers (PR #440)

@inexorabletash requested changes on this pull request.

Two more things:

* Add yourself to the Acknowledgements section
* Add an entry to the Revision History section

> @@ -6366,9 +6366,11 @@ steps may throw an exception.
       <!-- Binary -->
       : If |input| is a [=buffer source type=]
       ::
+          1. If [$IsDetachedBuffer$](|input|) is true then return invalid.

IsDetachedBuffer() takes an ArrayBuffer or a SharedArrayBuffer, but buffer source type includes the views. I think you'll need to dig the buffer out of the view in those cases?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/440#pullrequestreview-2642764852
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/IndexedDB/pull/440/review/2642764852@github.com>

Received on Wednesday, 26 February 2025 00:43:11 UTC