Re: [w3c/push-api] Expose pushManager on Window (PR #393)

@annevk commented on this pull request.



>              </li>
-            <li>When the request has been completed, [=queue a global task=] on the [=networking
-            task source=] using |global| to [=resolve=] |promise| with |subscription| and terminate
-            these steps.
+            <li>If |permission| is {{PermissionState/"denied"}}, [=queue a global task=] on the
+            [=user interaction task source=] using |global| to [=reject=] |promise| with a
+            {{"NotAllowedError"}} {{DOMException}} and terminate these steps.
+            </li>
+            <li>If |subscription| is non-null:
+              <ol>
+                <li>If there is an error with |subscription|, then [=queue a global task=] on the

I think we should keep this as this is not something I was aiming to change in this PR. I'm not really sure how to do it earlier though without getting very verbose.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/393#discussion_r1969907425
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/push-api/pull/393/review/2641314369@github.com>

Received on Tuesday, 25 February 2025 14:36:30 UTC