Re: [w3c/push-api] Expose pushManager on Window (PR #393)

@annevk commented on this pull request.



> @@ -578,7 +609,23 @@ <h3>
         </li>
         <li>Let |global| be [=this=]' [=relevant global object=].
         </li>
-        <li>Return |promise| and continue [=in parallel=].
+        <li>Let |scope| be null.
+        </li>
+        <li>Let |registration| be null.
+        </li>
+        <li>If [=this=] is a {{Window}} object, then set |scope| to the result of running the
+        [=basic URL parser=] given "`/`" and |global|'s <a>associated <code>Document</code></a>'s
+        [=Document/URL=].

I think you're correct that there might be some failure scenarios here this needs to account for.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/393#discussion_r1969897770
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/push-api/pull/393/review/2641289691@github.com>