Re: [w3c/ServiceWorker] Editorial: Queue a task to resolve/reject promise or when fire an event. (PR #1755)

@yoshisatoyanagisawa commented on this pull request.



> @@ -970,9 +971,10 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
         1. Let |promise| be [=a new promise=].
         1. Run the following steps [=in parallel=]:
             1. Let |registration| be [=this=]'s associated [=/service worker registration=].
-            1. If |registration|'s [=active worker=] is null, [=reject=] |promise| with an "{{InvalidStateError}}" {{DOMException}}, and abort these steps.
-            1. Set |registration|'s [=navigation preload enabled flag=].
-            1. Resolve |promise| with undefined.
+            1. [=Queue a task=] on |promise|'s [=relevant settings object=]'s [=responsible event loop=], using the [=DOM manipulation task source=], to run the following steps:
+                1. If |registration|'s [=active worker=] is null, [=reject=] |promise| with an "{{InvalidStateError}}" {{DOMException}}, and abort these steps.
+                1. Set |registration|'s [=navigation preload enabled flag=].

Stepping back and see if it is possible to update [=navigation prelaod flag=] from arbitrary location.
Then, I totally got confused.

`ServiceWorkerRegistration` has `NavigationPreloadManager` as a readonly object.  Then, I assume it is not possible to call `enable()`/`disable()` because it updates a field inside `NavigationPreloadManager`.  If it is allowed, then I suppose it technically possible to execute `enable()`/`disable()` from arbitrary ServiceWorker clients?  I suppose each client is loaded and executed asynchronously, and we might need to assume the case that the flag is changed during `Handle Fetch`.

Stepping back again, `Handle Fetch` just read a boolean flag, I guess the operation here is atomic.  Then, it might be fine to read/write it at the same time.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1755#discussion_r1969361894
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1755/review/2640293585@github.com>