- From: Yoshisato Yanagisawa <notifications@github.com>
- Date: Sun, 16 Feb 2025 21:16:55 -0800
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/ServiceWorker/pull/1755/review/2620048461@github.com>
@yoshisatoyanagisawa commented on this pull request.
> @@ -1271,10 +1275,10 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. Let |source| be the result of [=getting the service worker object=] that represents |contextObject|'s [=relevant global object=]'s [=ServiceWorkerGlobalScope/service worker=] in |targetClient|.
1. Let |deserializeRecord| be <a abstract-op>StructuredDeserializeWithTransfer</a>(|serializeWithTransferResult|, |destination|'s [=relevant Realm=]).
- If this throws an exception, catch it, [=fire an event=] named {{ServiceWorkerContainer/messageerror!!event}} at |destination|, using {{MessageEvent}}, with the {{MessageEvent/origin}} attribute initialized to |origin| and the {{MessageEvent/source}} attribute initialized to |source|, and then abort these steps.
+ If this throws an exception, catch it, [=queue a task=] to [=fire an event=] named {{ServiceWorkerContainer/messageerror!!event}} at |destination|, using {{MessageEvent}}, with the {{MessageEvent/origin}} attribute initialized to |origin| and the {{MessageEvent/source}} attribute initialized to |source|, and then abort these steps.
I feel this [=queue a task=] ambiguous. It may not tell whose queue is used for the purpose.
I suppose it targetClient's what do you think?
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1755#pullrequestreview-2620048461
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/ServiceWorker/pull/1755/review/2620048461@github.com>
Received on Monday, 17 February 2025 05:16:59 UTC