Re: [whatwg/fullscreen] Fix dangling fullscreen flag when exiting a disconnected element (PR #243)

Thanks @nt1m! I've looked at those results, and also run the tests manually in different browsers.

Chrome passes both remove-first.html and remove-last.html.

Firefox passes remove-first.html but fails remove-last.html. The failures is on [this assert](https://github.com/web-platform-tests/wpt/blob/2897a7bbe05d9b3e43deb694c7ffb5eb33d8f7a7/fullscreen/model/remove-last.html#L39), because `document.fullscreenElement` was synchronously changed to null instead of the first element being left as the fullscreen element. I assume this is because of the synchronous "fully exit fullscreen" call linked in https://github.com/whatwg/fullscreen/pull/243#issuecomment-2647847263.

Safari stable fails both tests, but per the results @nt1m shared the remove-first.html failures has been fixed. I can't tell from the failure message which exact assert failed. I've sent https://github.com/web-platform-tests/wpt/pull/50625 to make the tests more debuggable.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/243#issuecomment-2650545180
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/243/c2650545180@github.com>

Received on Tuesday, 11 February 2025 11:34:33 UTC