Re: [whatwg/fullscreen] Fix dangling fullscreen flag when exiting a disconnected element (PR #243)

> Per [#217 (comment)](https://github.com/whatwg/fullscreen/issues/217#issuecomment-2647289713) I think this is the right fix. I've sent #244 to fix Bikeshed errors so that this will build cleanly.

Thanks! I appreciate it.

> Also note that there is a remaining question mark in #133 that was filed while this very step was discussed in #128.

Hmm, I guess I don't feel too strongly. I just went with whatever Chrome shipped to fix the YouTube regression.

> I have reviewed https://github.com/web-platform-tests/wpt/blob/master/fullscreen/model/move-fullscreen-element.html and agree it's an appropriate test for this change. https://wpt.fyi/results/fullscreen/model/move-fullscreen-element.html?label=experimental&label=master&aligned shows it passing in Chrome/Edge/Firefox already.
> 
> However, I think the reason the test passes in Firefox is different. If the comment [here](https://searchfox.org/mozilla-central/rev/206eaea9a2fd4307da16e1614cd934920368165a/dom/base/Element.cpp#2319-2320) is correct, Gecko _fully_ exits fullscreen when the fullscreen element is removed.
> 
> The difference should be observable in a test written for #133.

I don't currently have time to do this, but I assume we could make a variant of the test that pushes 2 things in fullscreen, then moves one of them to see the difference?




-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/243#issuecomment-2648003829
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/243/c2648003829@github.com>