- From: Ben Francis <notifications@github.com>
- Date: Sat, 08 Feb 2025 00:01:32 -0800
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/1164@github.com>
PR #1163 added a definition of installable web applications. After code review comments had been addressed the resulting text included the sentence "Any website is an installable web application." I don't think that the vast majority of web developers would agree with this statement, and to me it seems to directly conflict with the text that follows which defines an _installed_ web application as one which has (or will have) a manifest applied to its top level browsing context. To me this clearly indicates that a website can not be an installable web application unless it at least has a web application manifest, even if only an empty manifest with defaults applied.
This is a suggestion to refine that text to address my review comments in #1163.
Specifically:
- What differentiates an installable web application from other websites is that it links to a web application manifest
- A manifest is applied when an installed web application is launched
This change:
* Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)
Commit message:
Refine the definition of an installable web application
Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:
* chore:
* editorial:
* BREAKING CHANGE:
* And use none if it's a normative change
<!--
This comment and the below content is programmatically generated.
You may add a comma-separated list of anchors you'd like a
direct link to below (e.g. #idl-serializers, #idl-sequence):
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/benfrancis/manifest/pull/1164.html" title="Last updated on Feb 8, 2025, 8:01 AM UTC (d668920)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/manifest/1164/2d9f760...benfrancis:d668920.html" title="Last updated on Feb 8, 2025, 8:01 AM UTC (d668920)">Diff</a>
You can view, comment on, or merge this pull request online at:
https://github.com/w3c/manifest/pull/1164
-- Commit Summary --
* editorial: Refine the definition of an installable web application
-- File Changes --
M index.html (9)
-- Patch Links --
https://github.com/w3c/manifest/pull/1164.patch
https://github.com/w3c/manifest/pull/1164.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1164
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/manifest/pull/1164@github.com>
Received on Saturday, 8 February 2025 08:01:36 UTC