- From: Frédéric Wang <notifications@github.com>
- Date: Sun, 02 Feb 2025 23:29:50 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 3 February 2025 07:29:54 UTC
@fred-wang commented on this pull request. > @@ -6519,6 +6529,11 @@ string <var>namespace</var> (default null):</p> <li><p>If <var>oldAttr</var> is <var>attr</var>, return <var>attr</var>. + <li><p>Let <var>verifiedValue</var> be the result of calling <a>verify attribute value</a> + <var>attr</var>'s <a for=Attr>value</a> for <var>attr</var>, with <var>element</var>. + + <li><p>Set <var>attr</var>'s <a for=Attr>value</a> to <var>verifiedValue</var>. + FWIW, in https://bugzilla.mozilla.org/show_bug.cgi?id=1944511 I'm adding new tests and will try to make sure this case and the other ones mentioned below are covered. But my guess would be we should just throw the same exception as in step 1 in that case: > 1 If attr’s [element](https://dom.spec.whatwg.org/#concept-attribute-element) is neither null nor element, [throw](https://webidl.spec.whatwg.org/#dfn-throw) an "[InUseAttributeError](https://webidl.spec.whatwg.org/#inuseattributeerror)" [DOMException](https://webidl.spec.whatwg.org/#idl-DOMException). -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1268#discussion_r1938903374 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1268/review/2589106699@github.com>
Received on Monday, 3 February 2025 07:29:54 UTC