- From: Daniel Murphy <notifications@github.com>
- Date: Tue, 30 Dec 2025 10:28:01 -0800
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/1199/review/3618969211@github.com>
@dmurph commented on this pull request.
> + The user agent SHOULD consider a [=manifest image resource=] updated
+ if the {{ImageResource/src}} member has changed. If the
+ {{ImageResource/src}} has not changed, the user agent MAY download the
+ image and check for visual differences in some cases.
I think this fits better above the
```
For the purpose of updating, the following member are
<dfn>security-sensitive members</dfn>, as they are presented during
installation and on launch surfaces:
```
section - e.g. before we talk about security sensitive. As this applies to all manifest resources.
That way we describe this in these sections:
- updating intro
- details about when things are considered changed (e.g. this section, we clarify about how images are considered for update)
- details about security sensitive vs not, and how to reason about that.
Also - I have a preference to name things "non-security-sensitive" and "security-sensitive" instead of "non security-sensitive" - this is because we are making 'security-sensitive" an adjective, and "non" is often hypthenated when used with words, and to be part of the adjective, I would (in my head) expect it to also be hyphenated with the other part. So - "non-security-sensitive" makes it concretely one concept.
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1199#pullrequestreview-3618969211
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/manifest/pull/1199/review/3618969211@github.com>
Received on Tuesday, 30 December 2025 18:28:05 UTC