Re: [whatwg/fetch] Add webtransport-hashes to request, wired down to create a connection (PR #1896)

@annevk commented on this pull request.

I rebased (which should address the CI issue you encountered) and pushed a commit addressing a number of nits. This looks good to me, but I have a couple of questions that might result in a couple more tweaks.

Note that I had to force push to your branch so you'll have to reset if you want to commit and push again.

> @@ -2248,6 +2248,19 @@ Unless stated otherwise, it is false.
 
 <p class=note>This flag is for exclusive use by HTML's render-blocking mechanism. [[!HTML]]
 
+<p>A <a for=/>request</a> has an associated <dfn export for=request>webtransport-hash list</dfn> (a

For this and equivalent terms, should we instead use the camelcase wording? E.g., "WebTransport-hash list"? Also, is this a list or a set because you used set/is not empty below?

> @@ -3003,16 +3016,19 @@ steps:
 <p>To <dfn export id=concept-connection-obtain>obtain a connection</dfn>, given a
 <a>network partition key</a> <var>key</var>, <a for=/>URL</a> <var>url</var>, boolean
 <var>credentials</var>, an optional <a>new connection setting</a> <var>new</var> (default
-"<code>no</code>"), and an optional boolean
-<dfn export for="obtain a connection"><var>requireUnreliable</var></dfn> (default false), run these
-steps:
-<!-- new's "yes-and-dedicated" and requireUnreliable have been added for WebTransport -->
+"<code>no</code>"), an optional boolean
+<dfn export for="obtain a connection"><var>requireUnreliable</var></dfn> (default false), and an
+optional <a for=/>webtransport-hash list</a>
+<dfn export for="obtain a connection"><var>webTransportHashes</var></dfn> (default « »):

Note that I made this a named parameter. I'm pretty sure that's needed as the prior parameter is named. I also fixed the default value.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1896#pullrequestreview-3591329817
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1896/review/3591329817@github.com>