Re: [whatwg/fetch] Add WebDriver BiDi network request logging (PR #1540)

@OrKoN commented on this pull request.



> @@ -4826,6 +4840,11 @@ steps:
      <a for=request>URL</a>, <var>fetchParams</var>'s <a for="fetch params">request</a>'s
      <a for=request>initiator type</a>, <var>global</var>, <var>cacheState</var>,
      <var>bodyInfo</var>, and <var>responseStatus</var>.
+
+     <li><p>If <var>response</var> is a <a>network error</a>, run
+     the <a>WebDriver BiDi fetch error</a> steps with <var>request</var>. Otherwise
+     run the <a>WebDriver BiDi response completed</a> steps with

I am not 100% sure that the linked line implies that the stream will be read resulting in the `WebDriver BiDi response completed` hook being called? or did you manage to trace it? Here it says that the body might still be enqueued https://fetch.spec.whatwg.org/#ref-for-concept-response-body%E2%91%A1%E2%91%A4:~:text=be%20a%20redirect).-,Return%20response.%20Typically%20response%E2%80%99s%20body%E2%80%99s%20stream%20is%20still%20being%20enqueued%20to%20after%20returning.,-4.8.%20CORS

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1540#discussion_r2607715119
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1540/review/3563881591@github.com>