Re: [whatwg/dom] Update element adoption logic for scoped registry (PR #1437)

@annevk approved this pull request.

Yeah I think this works. I'll re-review on Monday to be sure. If @sorvell, @rniwa, and maybe @keithamus could have a look as well that'd be great.

(Checking _inclusiveDescendant_'s custom element registry again bothers me a little bit, but I don't see a good way out of that. I also want to double check the "DocumentFragment  but not ShadowRoot" language.)

> +         <li><p>If <var>inclusiveDescendant</var>'s <a for=Element>custom element registry</a>
+         is non-null or <var>inclusiveDescendant</var>'s <a for=tree>parent</a> is null or
+         <var>inclusiveDescendant</var>'s <a for=tree>parent</a> is a {{DocumentFragment}} but not
+         a {{ShadowRoot}}, then set <var>registry</var> to <var>document</var>'s
+         <a for=Document>custom element registry</a>.

```suggestion
         <li><p>If <var>inclusiveDescendant</var>'s <a for=Element>custom element registry</a> is
         non-null, <var>inclusiveDescendant</var>'s <a for=tree>parent</a> is null, or
         <var>inclusiveDescendant</var>'s <a for=tree>parent</a> is a {{DocumentFragment}} but not
         a {{ShadowRoot}}, then set <var>registry</var> to <var>document</var>'s
         <a for=Document>custom element registry</a>.
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1437#pullrequestreview-3544990632
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1437/review/3544990632@github.com>