- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 27 Aug 2025 22:42:09 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 28 August 2025 05:42:12 UTC
@domenic approved this pull request.
LGTM with nit
> @@ -3241,7 +3241,8 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. Else if |source| is {{RouterSourceEnum/"cache"}}, or |source|["{{RouterSourceDict/cacheName}}"] [=map/exists=], then:
1. If |shouldSoftUpdate| is true, then [=in parallel=] run the [=Soft Update=] algorithm with |registration|.
1. Set |timingInfo|’s [=service worker timing info/worker cache lookup start=] to the [=coarsened shared current time=] given |useHighResPerformanceTimers|.
- 1. [=map/For each=] |cacheName| → |cache| of the |registration|'s [=service worker registration/storage key=]'s [=name to cache map=].
+ 1. Let |caches| be the result of running [=obtain a local storage bottle map=] with |reservedClient|, "<code>local</code>", and "<code>caches</code>".
```suggestion
1. Let |caches| be the result of running [=obtain a local storage bottle map=] with |reservedClient| and "<code>caches</code>".
```
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1786#pullrequestreview-3163241620
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/ServiceWorker/pull/1786/review/3163241620@github.com>
Received on Thursday, 28 August 2025 05:42:12 UTC