- From: Keith Cirkel <notifications@github.com>
- Date: Mon, 18 Aug 2025 04:55:29 -0700
- To: WICG/webcomponents <webcomponents@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <WICG/webcomponents/pull/1109/review/3127752905@github.com>
@keithamus commented on this pull request. > @@ -1,120 +1,332 @@ # Reference Target for Cross-Root ARIA -Author: [Ben Howell](https://github.com/behowell) +Original proposal author: [Ben Howell](https://github.com/behowell) ```suggestion Original proposal author: [Ben Howell](https://github.com/behowell) Current Author: [Alice Boxhall](https://github.com/alice) ``` > -Web components have an increasing number of features that allow them to work and act like builtin elements. For example: +For example, Spectrum Web Components' [`sp-checkbox` component](https://opensource.adobe.com/spectrum-web-components/components/checkbox/) +composes an `<input type=checkbox>`, +augmenting its functionality in several ways including adding an `indeterminate` state: It might be worth clarifying this augments by adding a `indeterminate` attribute which (I imagine) reflects the `indeteminate` IDL: https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/indeterminate I was a little confused initially reading this as I thought `indeterminate` was part of HTML, but it's just the IDL not the attribute. > ```html -<label for="fancy-input">Fancy input</label> -<fancy-input id="fancy-input"> - <template - shadowrootmode="closed" - shadowrootreferencetarget="real-input" - > - <input id="real-input"> +<button commandFor="pets"> +<md-dialog id="pets> ```suggestion <md-dialog id="pets"> ``` -- Reply to this email directly or view it on GitHub: https://github.com/WICG/webcomponents/pull/1109#pullrequestreview-3127752905 You are receiving this because you are subscribed to this thread. Message ID: <WICG/webcomponents/pull/1109/review/3127752905@github.com>
Received on Monday, 18 August 2025 11:55:33 UTC