Re: [w3c/permissions] Add an optional `topLevelOrigin` parameter to the `permissions.setPermission` command (PR #468)

@cfredric commented on this pull request.

I think this looks pretty good now, thanks!

>              <ol>
-              <li>Let |settings key| be be the result of [=powerful feature/permission key generation
-              algorithm|generating a permission key=] with |settings|'s [=origin=] and |settings|'s
-              [=environment/top-level origin=].
+              <li>Let |settings key| be be the result of [=powerful feature/permission key
+              generation algorithm|generating a permission key=] for |descriptor| with |settings|'s
+              [=origin=] and |settings|'s [=environment/top-level origin=].

```suggestion
              [=environment settings object/origin=] and |settings|'s [=environment/top-level origin=].
```

> @@ -1497,11 +1499,12 @@ <h6 id="webdriver-bidi-command-permissions-setPermission">
                   </li>
                   <li>Let |origin| be the value of the `origin` field of |command parameters|.
                   </li>
-                  <li>Let |embedding origin| be the value of the `embeddingOrigin` field of
+                  <li>Let |top level origin| be the value of the `topLevelOrigin` field of

It occurs to me that there's a type mismatch here - `top level origin` is defined to be a `text` value here, but later on we use it as if it were an `[=origin=]` (without parsing it or anything). This is an existing problem with how the spec handles the `origin` variable, too. Technically, the spec probably ought to [run a URL parser](https://url.spec.whatwg.org/#concept-url-parser) on the text to produce a [URL](https://url.spec.whatwg.org/#concept-url) and then access [the URL's origin](https://url.spec.whatwg.org/#concept-url-origin). Maybe there's a shorthand for doing all of that? 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/468#pullrequestreview-3122131310
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/permissions/pull/468/review/3122131310@github.com>