- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 14 Aug 2025 04:11:05 -0700
- To: w3c/push-api <push-api@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 14 August 2025 11:11:09 UTC
@annevk commented on this pull request. > + |windowScope|, then set |subscription| to that [=push subscription=]. + </li> + </ol> + </li> + <li>Otherwise: + <ol> + <li>[=/Assert=]: |registration| is non-null. + </li> + <li>If |registration|'s [=associated push subscription=] is non-null, then set + |subscription| to |registration|'s [=associated push subscription=]. + </li> + </ol> + </li> + <li>If |subscription| is null, then resolve |promise| with null. + </li> + <li>If there is an error with |subscription|, reject |promise| with a {{DOMException}} This is just trying to preserve existing text. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/push-api/pull/393#discussion_r2276320473 You are receiving this because you are subscribed to this thread. Message ID: <w3c/push-api/pull/393/review/3120161637@github.com>
Received on Thursday, 14 August 2025 11:11:09 UTC