- From: Anne van Kesteren <notifications@github.com>
- Date: Wed, 06 Aug 2025 07:52:54 -0700
- To: w3c/push-api <push-api@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 6 August 2025 14:52:58 UTC
@annevk commented on this pull request.
> - <li>Compare the |options| argument with the `options` attribute of |subscription|. The
- contents of {{BufferSource}} values are compared for equality rather than
- [=ECMAScript/reference record|reference=].
+ <li>Otherwise:
+ <ol>
+ <li>[=/Assert=]: |registration| is non-null.
+ </li>
+ <li>If |registration|'s [=service worker registration/active worker=] is null,
+ [=queue a global task=] on the [=networking task source=] using |global| to
+ [=reject=] |promise| with an {{"InvalidStateError"}} {{DOMException}} and terminate
+ these steps.
+ </li>
+ <li>If |registration|'s [=associated push subscription=] is non-null, then set
+ |subscription| to |registration|'s [=associated push subscription=].
+ </li>
+ <li>Set |scope| to |registration|'s [=service worker registration/scope URL=].
That's right.
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/393#discussion_r2257462774
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/push-api/pull/393/review/3093049944@github.com>
Received on Wednesday, 6 August 2025 14:52:58 UTC