- From: Anne van Kesteren <notifications@github.com>
- Date: Wed, 30 Apr 2025 01:08:31 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1821/review/2806151756@github.com>
@annevk commented on this pull request. I was about to approve this, but now I'm doubting it again. Is "from-browser-ui" really correct here? If I'm on a.com and click a link to b.com and b.com requires an end-user dialog, in that case we want the blank window as well, right? Perhaps the window cannot really be inferred from the client at all? > + <dd>The UI shown will be associated with the specified {{Window}} object. + </dl> +</div> + +<p>The <dfn for=request>appropriate user prompt context</dfn> for a <a for=/>request</a> +<var>request</var> is determined as follows: + +<ol> + <li><p><a>Assert</a>: <var>request</var>'s <a for=request>window</a> is not "<code>client</code>". + + <li><p>If the request's <a for=request>window</a> is an <a>environment settings object</a>, then + the prompt should occur in a way attributable to <var>request</var>'s <a for=request>window</a>. + + <li><p>Otherwise, if <var>request</var>'s <a for=request>window</a> is + "<code>from-browser-ui</code>", then the prompt should occur in a neutral context, e.g., on top of + a blank page. Should we note here that the address bar should probably contain some variation on the request's current URL? > @@ -6156,10 +6186,8 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps: <p>If the HTTP request results in a TLS client certificate dialog, then: <ol> - <li><p>If <var>request</var>'s <a for=request>window</a> - is an <a>environment settings object</a>, make the dialog - available in <var>request</var>'s - <a for=request>window</a>. + <li><p>If <var>request</var> has an <a>appropriate user prompt context</a>, then make the + dialog available in <var>request</var>'s <a>appropriate user prompt context</a>. ```suggestion dialog available therein. ``` Might be a bit nicer. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1821#pullrequestreview-2806151756 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1821/review/2806151756@github.com>
Received on Wednesday, 30 April 2025 08:08:35 UTC