- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 30 Apr 2025 00:07:34 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1820/review/2805980915@github.com>
@domenic commented on this pull request. > - "<code>no-window</code>". - - <li><p>If <var>request</var>'s <a for=request>origin</a> is "<code>client</code>", then set - <var>request</var>'s <a for=request>origin</a> to <var>request</var>'s <a for=request>client</a>'s - <a for="environment settings object">origin</a>. + <li> + <p>If <var>request</var>'s <a for=request>window</a> is "<code>client</code>": + + <ol> + <li><p>If <var>request</var>'s <a for=request>client</a> is non-null and <var>request</var>'s + <a for=request>client</a>'s <a for="environment settings object">global object</a> is a + {{Window}} object, then set <var>request</var>'s <a for=request>window</a> to + <var>request</var>'s <a for=request>client</a>'s + <a for="environment settings object">global object</a>. + + <li><p>Otherwise, set <var>request</var>'s <a for=request>window</a> to "<code>no-window</code>". Upon reflection, I think most spec authors will use the null client case for things from the network stack. They won't necessarily be super-esoteric... just "browser features" like FedCM or similar. So we might still want to do this automatically for them. Even if the browser UI navigation case goes a different path. I'll leave this PR open in case we do want to go this route, and open a separate PR for the browser UI navigation path. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1820#discussion_r2067998260 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1820/review/2805980915@github.com>
Received on Wednesday, 30 April 2025 07:07:38 UTC