- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 29 Apr 2025 23:17:18 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1820/review/2805860916@github.com>
@annevk commented on this pull request. > - "<code>no-window</code>". - - <li><p>If <var>request</var>'s <a for=request>origin</a> is "<code>client</code>", then set - <var>request</var>'s <a for=request>origin</a> to <var>request</var>'s <a for=request>client</a>'s - <a for="environment settings object">origin</a>. + <li> + <p>If <var>request</var>'s <a for=request>window</a> is "<code>client</code>": + + <ol> + <li><p>If <var>request</var>'s <a for=request>client</a> is non-null and <var>request</var>'s + <a for=request>client</a>'s <a for="environment settings object">global object</a> is a + {{Window}} object, then set <var>request</var>'s <a for=request>window</a> to + <var>request</var>'s <a for=request>client</a>'s + <a for="environment settings object">global object</a>. + + <li><p>Otherwise, set <var>request</var>'s <a for=request>window</a> to "<code>no-window</code>". This seems wrong for the null client case. Since I think a null client case is always a navigation (or perhaps something especially esoteric in the network stack) and thus would have a window to show dialogs in. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1820#pullrequestreview-2805860916 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1820/review/2805860916@github.com>
Received on Wednesday, 30 April 2025 06:17:22 UTC