- From: Marcos Cáceres <notifications@github.com>
- Date: Thu, 24 Apr 2025 04:22:22 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/1170/review/2790692719@github.com>
@marcoscaceres commented on this pull request.
suggestions
> @@ -300,27 +300,33 @@ <h3>
Declaring multiple icons
</h3>
<p>
- In the following example, the developer has made the following
- choices about the icons associated with the web application:
+ This section shows how to declare multiple icons using the
```suggestion
This section illustrates how to declare multiple icons using the
```
> @@ -300,27 +300,33 @@ <h3>
Declaring multiple icons
</h3>
<p>
- In the following example, the developer has made the following
- choices about the icons associated with the web application:
+ This section shows how to declare multiple icons using the
+ [=manifest/icons=] member to declare a set of icons for your web
Would need to check second-person usage?
```suggestion
[=manifest/icons=] member to declare a set of icons for a web
```
> back to the second icon of the same size. The <a>MIME type</a> of
this icon can then be either determined via a HTTP header, or can
be <a data-lt="computed mime type">sniffed</a> by the user agent
once the first few bytes of the icon are received.
</li>
- <li>The developer wants to use an SVG for greater than or equal to
- 257x257px. They've found that the SVG file looks too blurry at
- small sizes, even on high-density screens. To deal with this
- problem, the developer includes an SVG icon that is only used when
- the dimensions are at least 257px. Otherwise, the user agent uses
- the ICO file (hd_hi.ico), which includes a gamut of raster icons
- individually tailored for small display sizes.
+ <li>The developer specifies various sizes for the pixel-based icon
+ formats. These serve as hints for the user agent to determine a
```suggestion
formats (e.g., a ".png" file). These sizes serve as hints for the user agent to determine a
```
> back to the second icon of the same size. The <a>MIME type</a> of
this icon can then be either determined via a HTTP header, or can
be <a data-lt="computed mime type">sniffed</a> by the user agent
once the first few bytes of the icon are received.
</li>
- <li>The developer wants to use an SVG for greater than or equal to
- 257x257px. They've found that the SVG file looks too blurry at
- small sizes, even on high-density screens. To deal with this
- problem, the developer includes an SVG icon that is only used when
- the dimensions are at least 257px. Otherwise, the user agent uses
- the ICO file (hd_hi.ico), which includes a gamut of raster icons
- individually tailored for small display sizes.
+ <li>The developer specifies various sizes for the pixel-based icon
+ formats. These serve as hints for the user agent to determine a
+ suitable icon. The user has also included an ICO file (hd_hi.ico),
```suggestion
suitable icon to use in a particular context (e.g., on the home screen of a device). If the developer has also included an .ico file (e.g., hd_hi.ico),
```
> back to the second icon of the same size. The <a>MIME type</a> of
this icon can then be either determined via a HTTP header, or can
be <a data-lt="computed mime type">sniffed</a> by the user agent
once the first few bytes of the icon are received.
</li>
- <li>The developer wants to use an SVG for greater than or equal to
- 257x257px. They've found that the SVG file looks too blurry at
- small sizes, even on high-density screens. To deal with this
- problem, the developer includes an SVG icon that is only used when
- the dimensions are at least 257px. Otherwise, the user agent uses
- the ICO file (hd_hi.ico), which includes a gamut of raster icons
- individually tailored for small display sizes.
+ <li>The developer specifies various sizes for the pixel-based icon
+ formats. These serve as hints for the user agent to determine a
+ suitable icon. The user has also included an ICO file (hd_hi.ico),
+ which includes a gamut of raster icons individually tailored for
```suggestion
which includes a range of raster icons individually tailored for
```
> back to the second icon of the same size. The <a>MIME type</a> of
this icon can then be either determined via a HTTP header, or can
be <a data-lt="computed mime type">sniffed</a> by the user agent
once the first few bytes of the icon are received.
</li>
- <li>The developer wants to use an SVG for greater than or equal to
- 257x257px. They've found that the SVG file looks too blurry at
- small sizes, even on high-density screens. To deal with this
- problem, the developer includes an SVG icon that is only used when
- the dimensions are at least 257px. Otherwise, the user agent uses
- the ICO file (hd_hi.ico), which includes a gamut of raster icons
- individually tailored for small display sizes.
+ <li>The developer specifies various sizes for the pixel-based icon
+ formats. These serve as hints for the user agent to determine a
+ suitable icon. The user has also included an ICO file (hd_hi.ico),
+ which includes a gamut of raster icons individually tailored for
+ various sizes, and an SVG icon that can be resized dynamically to
```suggestion
particular display sizes. For example, it often not suitable to simply downscale a 256x256 image to display in a 16x16 context, as the image will have lost significant detail. Instead, and entirely different image specifically tailored for a 16x16 pixel context will often be used. On the other hand, an SVG icon that can be resized dynamically to
```
> back to the second icon of the same size. The <a>MIME type</a> of
this icon can then be either determined via a HTTP header, or can
be <a data-lt="computed mime type">sniffed</a> by the user agent
once the first few bytes of the icon are received.
</li>
- <li>The developer wants to use an SVG for greater than or equal to
- 257x257px. They've found that the SVG file looks too blurry at
- small sizes, even on high-density screens. To deal with this
- problem, the developer includes an SVG icon that is only used when
- the dimensions are at least 257px. Otherwise, the user agent uses
- the ICO file (hd_hi.ico), which includes a gamut of raster icons
- individually tailored for small display sizes.
+ <li>The developer specifies various sizes for the pixel-based icon
+ formats. These serve as hints for the user agent to determine a
+ suitable icon. The user has also included an ICO file (hd_hi.ico),
+ which includes a gamut of raster icons individually tailored for
+ various sizes, and an SVG icon that can be resized dynamically to
+ fit any icon size needed.
```suggestion
fit any icon size needed, but the tradeoff being that it can become unsuitable in some context (e.g., it becomes too small and blurry).
```
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1170#pullrequestreview-2790692719
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/manifest/pull/1170/review/2790692719@github.com>
Received on Thursday, 24 April 2025 11:22:25 UTC