Re: [w3c/ServiceWorker] Add race-network-and-cache source to static routing api. (PR #1764)

@monica-ch commented on this pull request.



> @@ -1591,14 +1591,16 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
 
       dictionary RouterSourceDict {
         DOMString cacheName;
+        DOMString raceNetworkAndCacheCacheName;

using a cacheName in the source indicate the source as "cache".  It is hard to identify the source if cacheName is used for both sources.

  e.addRoutes([
    {
      condition: {
        urlPattern: {pathname: "/race_network_and_cache_test_1"}
      },
      source: "race-network-and-cache" // Race b/w network and cache and without cache name indicates search all caches.
    },
     {
      condition: {
        urlPattern: "/race_network_and_cache_test_2",
      },
      source: {raceNetworkAndCacheCacheName: "test"} // Having `raceNetworkAndCacheCacheName` tells us to use race b/w network and cache source with the provided cacheName
     condition: {
        urlPattern: "/cache",
      },
      source: {cacheName: "test"} // existing example for cache source
  },
  ]);

This is in-line with the final form for Race-Network-and-cache - https://github.com/WICG/service-worker-static-routing-api/blob/main/final-form.md#race-network-and-cache-storage

@yoshisatoyanagisawa Correct me if this isn't expected


-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1764#discussion_r2050071761
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1764/review/2777614443@github.com>