- From: Yoshisato Yanagisawa <notifications@github.com>
- Date: Thu, 17 Apr 2025 16:35:25 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 17 April 2025 23:35:29 UTC
@yoshisatoyanagisawa commented on this pull request.
> @@ -3256,7 +3261,45 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. Let |fetchHandlerResponse| be the result of [=Create Fetch Event and Dispatch=] with |request|, |registration|, |useHighResPerformanceTimers|, |timingInfo|, |workerRealm|, |reservedClient|, |preloadResponse|, and |raceResponse|.
1. If |fetchHandlerResponse| is not null and not a [=network error=], and |raceFetchController| is not null, [=fetch controller/abort=] |raceFetchController|.
1. [=queue/Enqueue=] |fetchHandlerResponse| to |queue|.
- 1. Wait until |queue| is not empty.
+ 1. Set |fetchHandlerCompleted| to true.
+ 1. Wait until |queue| is not empty or (|networkFetchCompleted| is true and |fetchHandlerCompleted| is true).
Yes, I wanted to know how people usually write this because I have not seen specs using parentheses.
And, thank you for the advice.
@monica-ch Will you revise the sentences as @domenic's way?
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1764#discussion_r2049757008
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/ServiceWorker/pull/1764/review/2777128350@github.com>
Received on Thursday, 17 April 2025 23:35:29 UTC