Re: [whatwg/encoding] Explain the relationship between windows-1252, Latin1, and ASCII (PR #345)

@annevk commented on this pull request.



> @@ -14,7 +14,14 @@ def create_table():
             if label_len > 1:
                 rowspan = " rowspan=" + str(label_len)
 
-            table += "  <tr>\n   <td" + rowspan + "><a>" + encoding["name"] + "</a>"
+            if encoding["name"] != "windows-1252":
+                table += "  <tr><td" + rowspan + ">" + encoding["name"] + "\n"
+            else:
+                table += f"""  <tr>
+   <td{rowspan}>
+    <a>{encoding["name"]}</a>
+    <p class=note>See <a href="#note-latin1-ascii">below</a> for the relationship to historical
+    "Latin1" and "ASCII" concepts."""

I took a more detailed look and pushed a fixup. Should be okay to land now from my perspective.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/pull/345#discussion_r2048532651
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/encoding/pull/345/review/2775059941@github.com>