- From: Yoshisato Yanagisawa <notifications@github.com>
- Date: Wed, 16 Apr 2025 21:57:00 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/ServiceWorker/pull/1764/review/2774573996@github.com>
@yoshisatoyanagisawa commented on this pull request. > + 1. If |shouldSoftUpdate| is true, then [=in parallel=] run the [=Soft Update=] algorithm with |registration|. + 1. Let |queue| be an empty [=queue=] of [=/response=]. + 1. Let |raceFetchController| be null. + 1. Let |raceResponse| be a [=race response=] whose [=race response/value=] is "<code>pending</code>". + 1. Let |networkFetchCompleted| be false. + 1. Let |cacheLookupCompleted| be false. + 1. Run the following substeps [=in parallel=], but [=abort when=] |fetchController|'s [=fetch controller/state=] is "<code>terminated</code>" or "<code>aborted</code>": + 1. Set |raceFetchController| to the result of calling [=fetch=] given |request|, with [=fetch/processResponse=] set to the following steps given a [=/response=] |raceNetworkRequestResponse|: + 1. If |raceNetworkRequestResponse|'s [=response/status=] is [=ok status=], then: + 1. Set |raceResponse|'s [=race response/value=] to |raceNetworkRequestResponse|. + 1. [=queue/Enqueue=] |raceNetworkRequestResponse| to |queue|. + 1. Otherwise, set |raceResponse|'s [=race response/value=] to a [=network error=]. + 1. Set |networkFetchCompleted| to true. + 1. [=If aborted=] and |raceFetchController| is not null, then: + 1. If |raceFetchController|'s [=fetch controller/state=] is not "<code>terminated</code>", [=fetch controller/abort=] |raceFetchController|. + 1. Set |raceResponse| to a [=race response=] whose [=race response/value=] is null. Also |networkFetchComplete| for this. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1764#pullrequestreview-2774573996 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1764/review/2774573996@github.com>
Received on Thursday, 17 April 2025 04:57:04 UTC