- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 16 Apr 2025 18:02:06 -0700
- To: whatwg/encoding <encoding@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 17 April 2025 01:02:10 UTC
@domenic commented on this pull request.
> @@ -14,7 +14,14 @@ def create_table():
if label_len > 1:
rowspan = " rowspan=" + str(label_len)
- table += " <tr>\n <td" + rowspan + "><a>" + encoding["name"] + "</a>"
+ if encoding["name"] != "windows-1252":
+ table += " <tr><td" + rowspan + ">" + encoding["name"] + "\n"
+ else:
+ table += f""" <tr>
+ <td{rowspan}>
+ <a>{encoding["name"]}</a>
+ <p class=note>See <a href="#note-latin1-ascii">below</a> for the relationship to historical
+ "Latin1" and "ASCII" concepts."""
I added one, and indeed the Python script output is more consistent now, but the main text doesn't match the Python script output: all the blank lines are omitted. Not sure what to do about that, if anything.
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/pull/345#discussion_r2048023028
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/encoding/pull/345/review/2774261047@github.com>
Received on Thursday, 17 April 2025 01:02:10 UTC