Re: [whatwg/encoding] Explain the relationship between windows-1252, Latin1, and ASCII (PR #345)

@annevk approved this pull request.

Looks good modulo formatting nits.

> @@ -14,7 +14,14 @@ def create_table():
             if label_len > 1:
                 rowspan = " rowspan=" + str(label_len)
 
-            table += "  <tr>\n   <td" + rowspan + "><a>" + encoding["name"] + "</a>"
+            if encoding["name"] != "windows-1252":
+                table += "  <tr><td" + rowspan + ">" + encoding["name"] + "\n"
+            else:
+                table += f"""  <tr>
+   <td{rowspan}>
+    <a>{encoding["name"]}</a>
+    <p class=note>See <a href="#note-latin1-ascii">below</a> for the relationship to historical
+    "Latin1" and "ASCII" concepts."""

I suspect this is missing a newline at the end.

> @@ -732,6 +747,29 @@ part of the ISO 8859 series. In particular, the necessity of the inclusion of <a
 and <a>ISO-8859-16</a> is doubtful for the purpose of supporting existing content, but there are no
 plans to remove these.</p>
 
+<div class=note id=note-latin1-ascii> <p>The <a>windows-1252</a> <a for=/>encoding</a> has various

A newline got eaten here. And indentation is messed up as a result?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/pull/345#pullrequestreview-2771862979
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/encoding/pull/345/review/2771862979@github.com>