Re: [whatwg/dom] Add Scoped Custom Element Registries (PR #1341)

@keithamus commented on this pull request.



> @@ -5668,6 +5756,34 @@ method steps are to return the result of running the
 <a>internal <code>createElementNS</code> steps</a>, given <a>this</a>, <var>namespace</var>,
 <var>qualifiedName</var>, and <var>options</var>.
 
+<p>To <dfn>flatten element creation options</dfn>, given a string or {{ElementCreationOptions}}
+dictionary <var>options</var> and a <a for=/>document</a> <var>document</var>:
+
+<ol>
+ <li><p>Let <var>registry</var> be null.
+
+ <li><p>Let <var>is</var> be null.
+
+ <li>
+  <p>If <var>options</var> is a dictionary:

I think we're missing the alternate case here, for when `options` is a string - `is` is never set to `options` AFAICT.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1341#pullrequestreview-2764781845
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1341/review/2764781845@github.com>