Re: [w3ctag/design-reviews] WebXR Device API (delta/aiming 2nd CRS) (Issue #983)

Thanks for your review request—and for highlighting the changes since last time. Here are a few comments on these changes.

HT @m-alkalbani for assisting with the review.

1. Expose XRSession’s granted features ([GitHub \#1296](https://github.com/immersive-web/webxr/pull/1296))

   Looks good!

2. Add support for the isSystemKeyboardSupported attribute ([GitHub \#1314](https://github.com/immersive-web/webxr/pull/1314))

   This Boolean's name starts with 'is' whereas others' names don't seem to. Is there a reason for this, such as consistency with other specs? It seems inconsistent with other parts of WebXR Device API.

3. Clarify getPose behavior with visibile-blurred ([GitHub \#1332](https://github.com/immersive-web/webxr/pull/1332))

   Looks good!

4. Transient intent addition ([GitHub \#1343](https://github.com/immersive-web/webxr/pull/1343))

   This looks good — but gave rise to a question about an instance of one of the terms used in the [definition of `targetRayMode` enum values](https://www.w3.org/TR/2024/CRD-webxr-20240805/#dom-xrinputsource-targetraymode)...

   Assuming that the `gaze` enum variant is talking about getting input from the direction someone's head is facing...

   The [definition for the `transient-pointer` enum variant](https://www.w3.org/TR/2024/CRD-webxr-20240805/#dom-xrtargetraymode-transient-pointer) states: "Some examples are user intents based on information too sensitive to expose directly such as gaze..." — however in this phrase, is "gaze" actually referring to input that comes from _eye_ gaze (i.e. eye tracking)? If so, the word "gaze" is referring to two differnet things; would you be able to re-phrase this to make that clear?

5. First draft for adding a property to XRInputSource to say it’s visible elsewhere ([GitHub \#1353](https://github.com/immersive-web/webxr/pull/1353))

   This looks good — but the PR referenced here should be 1352, so the Changes section should be updated.

6. Clarify rgb vs srgb behavior ([GitHub \#1359](https://github.com/immersive-web/webxr/pull/1359))

   We want to keep reminding people to try to align colors between CSS, canvas, and the other drawing surfaces in the platform. That said, that's a long-term project, and we don't expect this incremental change to solve it. Otherwise looks good!

Also...

7. [The definition for `transient-pointer`](https://www.w3.org/TR/2024/CRD-webxr-20240805/#dom-xrtargetraymode-transient-pointer) has a typo; it mentions "W3C design principals" — I think you mean to reference [Web Design Principle 2.9: Don’t reveal that assistive technologies are being used](https://www.w3.org/TR/design-principles/#do-not-expose-use-of-assistive-tech); if so, perhaps you could include this link.

   That you made the reference, and read the principles, is appreciated!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3ctag/design-reviews/issues/983#issuecomment-2359442988
You are receiving this because you are subscribed to this thread.

Message ID: <w3ctag/design-reviews/issues/983/2359442988@github.com>