Re: [whatwg/encoding] Adopt GB18030-2022 (PR #336)

@hsivonen approved this pull request.

Technically LGTM, but please 1) revise the informative description of index-gb18030-ranges.txt and 2) please re-run the visualization generator script.

Thanks.

> @@ -845,7 +845,7 @@ specification, excluding <a>index single-byte</a>, which have their own table:
   <td colspan=3><a href=index-gb18030-ranges.txt>index-gb18030-ranges.txt</a>
   <td>This <a>index</a> works different from all others. Listing all code points would result
   in over a million items whereas they can be represented neatly in 207 ranges combined with trivial
-  limit checks. It therefore only superficially matches the GB18030-2005 standard for code points
+  limit checks. It therefore only superficially matches the GB18030-2022 standard for code points

Hmm. Since index-gb18030-ranges.txt does not get entry changes, perhaps the remark here should more clearly explain why -ranges.txt matches GB18030-2005 and not -2022.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/pull/336#pullrequestreview-2313229015
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/encoding/pull/336/review/2313229015@github.com>