Re: [whatwg/streams] Commit pull-into descriptors after filling from queue (PR #1326)

@domenic commented on this pull request.



> +    if (SafeCopyDataBlockBytes(pullIntoDescriptor.buffer, destStart, headOfQueue.buffer, headOfQueue.byteOffset,
+                               bytesToCopy) === false) {
+      // This should never happen. Please report an issue if it does! https://github.com/whatwg/streams/issues
+      const e = new TypeError('Invalid buffer');
+      ReadableByteStreamControllerError(controller, e);
+      return false;
+    }

My preference is an assertion. Perhaps in the spec it's an assertion with a big `<p class="warning">` suggesting that implementers really might want to consider crashing if the assertions somehow gets violated?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1326#discussion_r1753141620
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1326/review/2295551030@github.com>