- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 24 Oct 2024 14:31:17 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 24 October 2024 21:31:21 UTC
@annevk commented on this pull request.
Thanks for the patch!
If you rebase against main the build error should go away. I just fixed that.
> @@ -4509,6 +4509,8 @@ steps:
"<code>http</code>"
<li><var>request</var>'s <a for=request>current URL</a>'s <a for=url>host</a> is a
<a for=/>domain</a>
+ <li><var>request</var>'s <a for=request>current URL</a>'s <a for=url>host</a>'s
+ <a for=host>public suffix</a> is not " localhost " or " localhost. "
Please use the same syntax we use in "resolve an origin". I guess in due course we are gonna need an abstraction for this.
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1781#pullrequestreview-2393738902
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/fetch/pull/1781/review/2393738902@github.com>
Received on Thursday, 24 October 2024 21:31:21 UTC