- From: Martin Thomson <notifications@github.com>
- Date: Wed, 16 Oct 2024 17:54:25 -0700
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 17 October 2024 00:54:29 UTC
I don't know if I understand well enough to review. As far as I can see, you commit something if `result` OR `asURL` are non-null. That `asURL` bit seems off, but I wasn't able to confirm. (Funny how GitHub stops working properly for like 110k of a file, even if the diff is modest in size, almost like it is a bad idea to have files that large). -- Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/980#issuecomment-2418265549 You are receiving this because you are subscribed to this thread. Message ID: <w3ctag/design-reviews/issues/980/2418265549@github.com>
Received on Thursday, 17 October 2024 00:54:29 UTC