- From: Joshua Bell <notifications@github.com>
- Date: Thu, 10 Oct 2024 09:38:15 -0700
- To: w3c/IndexedDB <IndexedDB@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 10 October 2024 16:38:19 UTC
@inexorabletash requested changes on this pull request. > @@ -5636,13 +5643,17 @@ To <dfn>store a record into an object store</dfn> with To <dfn>retrieve a value from an object store</dfn> with |targetRealm|, |store| and |range|, run these steps: +NOTE: + May return a {{DOMException}} if an error occurs while running these steps. Avoid "may" as that has [RFC 2119](https://datatracker.ietf.org/doc/html/rfc2119) meaning, i.e. it means that the specified behavior is optional for implementations. Also, it should be normative. https://infra.spec.whatwg.org/#algorithm-declaration has the preferred formulation, which is: > ..., perform the following steps. They return ... So maybe: > ... run these steps. They return a value from the object store, or an error (a DOMException). > @@ -5654,6 +5665,9 @@ To <dfn>retrieve a value from an object store</dfn> with To <dfn>retrieve multiple values from an object store</dfn> with |targetRealm|, |store|, |range| and optional |count|, run these steps: +NOTE: Same as above. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/IndexedDB/pull/430#pullrequestreview-2360893307 You are receiving this because you are subscribed to this thread. Message ID: <w3c/IndexedDB/pull/430/review/2360893307@github.com>
Received on Thursday, 10 October 2024 16:38:19 UTC