Re: [whatwg/dom] Introduce `moveBefore()` state-preserving atomic move API (PR #1307)

@domfarolino commented on this pull request.



> +   <li>
+    <p>Otherwise, <a lt="try to upgrade an element">try to upgrade</a>
+    <var>inclusiveDescendant</var>.
+
+    <p class=note>If this successfully upgrades <var>inclusiveDescendant</var>, its
+    <code>connectedCallback</code> will be enqueued automatically during the
+    <a>upgrade an element</a> algorithm.
+   </li>

OK yeah I had to get educated a bit more on exactly how custom elements work and upgrade, but I agree this is not relevant for this PR. It's now removed; resolving.

> + null, null, null, <var>addedNodes</var>, <var>removedNodes</var>, <var>previousSibling</var>, and
+ <var>nextSibling</var>.

Ah yes, at some point during the mutation observer design, I did have to introduce legitimate changes to this line. Its lingering effects are an oversight. Done.

> @@ -4118,6 +4293,8 @@ interface Node : EventTarget {
   [CEReactions] Node appendChild(Node node);
   [CEReactions] Node replaceChild(Node node, Node child);
   [CEReactions] Node removeChild(Node child);
+

Done.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1307#discussion_r1861213623
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1307/review/2465851816@github.com>