- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 26 Nov 2024 00:23:07 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 26 November 2024 08:23:10 UTC
@annevk commented on this pull request. > + <li> + <p>Otherwise, <a lt="try to upgrade an element">try to upgrade</a> + <var>inclusiveDescendant</var>. + + <p class=note>If this successfully upgrades <var>inclusiveDescendant</var>, its + <code>connectedCallback</code> will be enqueued automatically during the + <a>upgrade an element</a> algorithm. + </li> How could this happen due to a move? That seems incorrect? > + null, null, null, <var>addedNodes</var>, <var>removedNodes</var>, <var>previousSibling</var>, and + <var>nextSibling</var>. Let's not change this in this PR. > @@ -4118,6 +4293,8 @@ interface Node : EventTarget { [CEReactions] Node appendChild(Node node); [CEReactions] Node replaceChild(Node node, Node child); [CEReactions] Node removeChild(Node child); + I don't think we need this newline here. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1307#pullrequestreview-2460730164 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1307/review/2460730164@github.com>
Received on Tuesday, 26 November 2024 08:23:10 UTC