- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 25 Nov 2024 22:57:41 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/streams/pull/1333@github.com>
Although a better fix might be to delay size calculation until we've verified that we're not in the erroring or errored states, that has observable differences for certain bad-strategy cases already in the WPT suite, and multiple implementations seem to have converged on this particular fix already. Closes #1331. <!-- Thank you for contributing to the Streams Standard! Please describe the change you are making and complete the checklist below if your change is not editorial. When editing this comment after the PR is created, check that PR-Preview doesn't overwrite your changes. If you think your PR is ready to land, please double-check that the build is passing and the checklist is complete before pinging. --> - [x] At least two implementers are interested (and none opposed): * Already implemented in Chrome * Already implemented in Firefox - [x] [Tests](https://github.com/web-platform-tests/wpt) are written and can be reviewed and commented upon at: * Already tested - [ ] [Implementation bugs](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) are filed: * Chromium: N/A * Gecko: N/A * WebKit: TBD what they're doing * Deno: TBD * Node.js: TBD - [x] [MDN issue](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) is filed: small edge case; N/A - [x] The top of this comment includes a [clear commit message](https://github.com/whatwg/meta/blob/main/COMMITTING.md) to use. <!-- If you created this PR from a single commit, Github copied its message. Otherwise, you need to add a commit message yourself. --> (See [WHATWG Working Mode: Changes](https://whatwg.org/working-mode#changes) for more details.) <!-- This comment and the below content is programmatically generated. You may add a comma-separated list of anchors you'd like a direct link to below (e.g. #idl-serializers, #idl-sequence): Don't remove this comment or modify anything below this line. If you don't want a preview generated for this pull request, just replace the whole of this comment's content by "no preview" and remove what's below. --> *** <a href="https://whatpr.org/streams/1333.html" title="Last updated on Nov 26, 2024, 6:57 AM UTC (bd98d4d)">Preview</a> | <a href="https://whatpr.org/streams/1333/8ebee1f...bd98d4d.html" title="Last updated on Nov 26, 2024, 6:57 AM UTC (bd98d4d)">Diff</a> You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/1333 -- Commit Summary -- * Fix attempting to get the chunk size after strategy is cleared -- File Changes -- M index.bs (4) M reference-implementation/lib/abstract-ops/writable-streams.js (5) -- Patch Links -- https://github.com/whatwg/streams/pull/1333.patch https://github.com/whatwg/streams/pull/1333.diff -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1333 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/streams/pull/1333@github.com>
Received on Tuesday, 26 November 2024 06:57:44 UTC