- From: Dominic Farolino <notifications@github.com>
- Date: Fri, 22 Nov 2024 07:12:30 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 22 November 2024 15:12:34 UTC
@domfarolino commented on this pull request. So I came across this in my inbox, very belatedly, but the PR seems to have been in a lull for a bit. What is the current status? Seems there are a few comment threads that are open and unresolved, but no major blockers identified I guess? Let me know if I can help. > @@ -7435,7 +7492,13 @@ string <var>value</var>, run these steps: <li><p>If <var>attribute</var>'s <a for=Attr>element</a> is null, then set <var>attribute</var>'s <a for=Attr>value</a> to <var>value</var>. - <li><p>Otherwise, <a lt="change an attribute">change</a> <var>attribute</var> to <var>value</var>. + <li><p>Otherwise: + <ol> + <li><p>Let <var>verifiedValue</var> be the result of calling <a>verify attribute value</a> + <var>value</var> for <var>attribute</var>, with <a>this</a>. + + <li><p><a lt="change an attribute">Change</a> <var>attribute</var> to <var>verifiedValue</var>. Indenting of this line is wrong. Either that, or the first `<li>` above is indented wrong. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1268#pullrequestreview-2454695394 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1268/review/2454695394@github.com>
Received on Friday, 22 November 2024 15:12:34 UTC