- From: Andreas Kling <notifications@github.com>
- Date: Sat, 16 Nov 2024 02:17:21 -0800
- To: w3c/selection-api <selection-api@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/selection-api/pull/342@github.com>
This matches how major engines behave and is covered by multiple tests in WPT already.
Closes #118.
Supersedes #86.
Note: I didn't touch `setBaseAndExtent` here, since Gecko throws on doctype but WebKit and Blink don't.
<!--
This comment and the below content is programmatically generated.
You may add a comma-separated list of anchors you'd like a
direct link to below (e.g. #idl-serializers, #idl-sequence):
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/awesomekling/selection-api/pull/342.html" title="Last updated on Nov 16, 2024, 10:17 AM UTC (2679812)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/selection-api/342/97a072c...awesomekling:2679812.html" title="Last updated on Nov 16, 2024, 10:17 AM UTC (2679812)">Diff</a>
You can view, comment on, or merge this pull request online at:
https://github.com/w3c/selection-api/pull/342
-- Commit Summary --
* Throw InvalidNodeTypeError for doctype more eagerly
-- File Changes --
M index.html (6)
-- Patch Links --
https://github.com/w3c/selection-api/pull/342.patch
https://github.com/w3c/selection-api/pull/342.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/selection-api/pull/342
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/selection-api/pull/342@github.com>
Received on Saturday, 16 November 2024 10:17:25 UTC