- From: Noam Rosenthal <notifications@github.com>
- Date: Tue, 12 Nov 2024 07:48:02 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/1307/review/2429989830@github.com>
@noamr commented on this pull request. > + <li><p>Let <var>oldParent</var> be <var>node</var>'s <a for=tree>parent</a>. + + <li><p><a>Assert</a>: <var>oldParent</var> is non-null. + + <li><p>Let <var>index</var> be <var>node</var>'s <a for=tree>index</a>. + + <li> + <p>For each <a>live range</a> whose <a for=range>start node</a> is <var>parent</var> and + <a for=range>start offset</a> is greater than <var>index</var>, decrease its + <a for=range>start offset</a> by 1.</p> + + <p class="note">Note that unlike the traditional <a for=/ lt="remove">removal</a> case, we do not + need to update <a>live range</a> state when their <a for=range>start node</a> or + <a for=range>end node</a> is an <a>inclusive descendant</a> of the <var>node</var>. This is + because said <a>nodes</a> do not get removed from their <a>tree</a>, so ranges associated with + them stay intact.</p> @smaug---- perhaps a useful middle ground can be that we preserve the selection only if the moved node is an ancestor of the entire range. This way if the range is moved while "intact", the selection would be preserved, but if parts of it are moved it's considered "broken" and it's dissolved. This is useful when moving whole elements which might have bits of text selected inside them. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1307#discussion_r1838339343 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1307/review/2429989830@github.com>
Received on Tuesday, 12 November 2024 15:48:06 UTC