- From: smaug---- <notifications@github.com>
- Date: Mon, 11 Nov 2024 02:54:53 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/1307/review/2426974697@github.com>
@smaug---- commented on this pull request. > @@ -2652,6 +2652,50 @@ of a <var>node</var> into a <var>parent</var> before a <var>child</var>, run the <!-- Technically this is post-insert. --> </ol> +<p>To <dfn export for=Node id=concept-node-ensure-pre-move-validity>ensure pre-move validity</dfn> +of a <var>node</var> into a <var>parent</var> before a <var>child</var>, run these steps: + +<ol> + <li><p>If either <var>parent</var> or <var>node</var> are not <a>connected</a>, then + <a>throw</a> a "{{HierarchyRequestError!!exception}}" {{DOMException}}.</p></li> + + <li><p>If <var>parent</var>'s <a for=/>shadow-including root</a> is not the same as + <var>node</var>'s <a for=/>shadow-including root</a>, then <a>throw</a> a + "{{HierarchyRequestError!!exception}}" {{DOMException}}.</p></li> + + <li><p>If <var>parent</var> is not an {{Element}} <a for=/>node</a>, then <a>throw</a> a + "{{HierarchyRequestError!!exception}}" {{DOMException}}. Shadowroot is a DocumentFragment. I would expect moves under ShadowRoot being possible. (I wasn't thinking the connectedness case here, only that one should be able reorder the children of a ShadowRoot) -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1307#discussion_r1836482758 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1307/review/2426974697@github.com>
Received on Monday, 11 November 2024 10:54:57 UTC