Re: [whatwg/dom] Introduce DOM post-connection steps (PR #1261)

@annevk approved this pull request.

I plan on merging this next week Wednesday assuming there's no further comments.

> @@ -2752,6 +2809,30 @@ before a <var>child</var>, with an optional <i>suppress observers flag</i>, run
  <var>parent</var> with <var>nodes</var>, « », <var>previousSibling</var>, and <var>child</var>.
 
  <li><p>Run the <a>children changed steps</a> for <var>parent</var>.
+
+ <li>
+  <p>Let <var>staticNodeList</var> be a <a for=/>list</a> of <a for=/>nodes</a>, initially « ».</p>
+
+  <p class="note">We collect all <a for=/>nodes</a> <em>before</em> calling the
+  <a>post-connection steps</a> on any one of them, instead of calling the
+  <a>post-connection steps</a> <em>while</em> we're traversing the <a>node tree</a>. This is because
+  the <a>post-connection steps</a> can modify the tree's structure, making live traversal unsafe,
+  possibly leading to the <a>post-connection steps</a> being called multiple times on the same
+  <a>node</a>.</p>
+ </li>
+
+ <li>
+  <p>For each <var>node</var> in <var>nodes</var>, in <a>tree order</a>:

```suggestion
  <p>For each <var>node</var> of <var>nodes</var>, in <a>tree order</a>:
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1261#pullrequestreview-2091283578
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1261/review/2091283578@github.com>

Received on Friday, 31 May 2024 16:40:15 UTC