- From: Dominic Farolino <notifications@github.com>
- Date: Mon, 13 May 2024 07:52:29 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/1261/review/2052945931@github.com>
@domfarolino commented on this pull request. > + modify the tree's structure, making live traversal unsafe, possibly leading to the + <a>post-insertion steps</a> being called multiple times on the same <a>node</a>.</p> + </li> + + <li> + <p>For each <var>node</var> in <var>nodes</var>, in <a>tree order</a>: + + <ol> + <li><p>For each <a>shadow-including inclusive descendant</a> <var>inclusiveDescendant</var> of + <var>node</var>, in <a>shadow-including tree order</a>, <a for=list>append</a> + <var>inclusiveDescendant</var> to <var>staticNodeList</var>. + </ol> + </li> + + <li><p><a for=list>For each</a> <var>node</var> in <var>staticNodeList</var>, if <var>node</var> is + <a>connected</a>, then run the <a>post-insertion steps</a> with <var>node</var>. I'm assuming you mean Chromium and WebKit? Either way, yes that sounds good to me. Latest commit here renames everything accordingly. I went with `post-connection steps` instead of `post-connected` steps, since `post-connection` is similar to `post-insertion` which is what this PR had before the rename (i.e., we didn't choose `post-inserted steps`). I'm indifferent; if you think it should be renamed to `post-connected` let me know! -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1261#discussion_r1598615173 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1261/review/2052945931@github.com>
Received on Monday, 13 May 2024 14:52:33 UTC